Skip to content

Alternative approach for integration with Vuetify #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 6, 2020
Merged

Alternative approach for integration with Vuetify #123

merged 4 commits into from
Mar 6, 2020

Conversation

mediafreakch
Copy link
Contributor

I suggest an alternative approach to the problem to preserve things like props, propsData, updateProps that are applied to the root node only.

@mediafreakch
Alternative approach to preserve mountOptions
ce9f541 
I suggest an alternative approach to the problem to preserve things like `props, propsData, updateProps` that are applied to the root node only.
@codecov
Copy link

codecov bot commented Mar 6, 2020 •
edited
Loading

Codecov Report

Merging #123 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           67        67           
  Branches        13        13           
=========================================
  Hits            67        67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850bd4c...d36ab03. Read the comment docs.

@mediafreakch mediafreakch changed the title Alternative approach to preserve mountOptions Alternative approach for integration with Vuetify Mar 6, 2020
afontcu
afontcu reviewed Mar 6, 2020
View reviewed changes
Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks way better, thank you! I've added a couple of suggestions, then we're ready to merge 😄

@afontcu afontcu merged commit a2c0f6f into testing-library:master Mar 6, 2020
@afontcu
Copy link
Member

afontcu commented Mar 6, 2020

Thanks for this! :)

@afontcu afontcu mentioned this pull request Mar 6, 2020
Merged
@mediafreakch
Copy link
Contributor Author

@afontcu I was wondering if #122 might be somehow related, even though I'm not extending the render method there...

@mediafreakch mediafreakch deleted the patch-1 branch March 6, 2020 12:59
@afontcu
Copy link
Member

afontcu commented Mar 13, 2020

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mediafreakch mediafreakch mentioned this pull request Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afontcu afontcu afontcu left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mediafreakch @afontcu